Skip to content

bpo-42994: Add MIME types for opus, AAC, 3gpp and 3gpp2 #24287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2021
Merged

bpo-42994: Add MIME types for opus, AAC, 3gpp and 3gpp2 #24287

merged 2 commits into from
Mar 3, 2021

Conversation

ndbeals
Copy link
Contributor

@ndbeals ndbeals commented Jan 21, 2021 •
edited by bedevere-bot
Loading

Add MIME types for opus, AAC, 3gpp and 3gpp2. Some types have multiple extensions, the IANA preferred extension comes first.

These are officially recognized MIME types by IANA: https://www.iana.org/assignments/media-types/media-types.xhtml#audio

https://bugs.python.org/issue42994

@ndbeals ndbeals requested a review from a team as a code owner January 21, 2021 22:09
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 21, 2021
@ndbeals
Copy link
Contributor Author

ndbeals commented Feb 23, 2021 •
edited
Loading

I've pinged the issue on the python bug tracker as per the contributing guidelines.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 24, 2021
@ypankovych
Copy link
Contributor

LGTM

orsenthil
orsenthil approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@orsenthil orsenthil merged commit 3a87e56 into python:master Mar 3, 2021
@bedevere-bot
Copy link

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@ndbeals
Copy link
Contributor Author

ndbeals commented Mar 3, 2021

Thanks for reviewing and merging this.

@tirkarthi tirkarthi mentioned this pull request Jun 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil approved these changes

@FFY00 FFY00 FFY00 approved these changes

+1 more reviewer

@ypankovych ypankovych ypankovych approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ndbeals @ypankovych @bedevere-bot @orsenthil @FFY00 @the-knights-who-say-ni