Skip to content

bpo-42035: Add a PyType_GetName() to get type's short name. #23903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 29, 2021

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Dec 23, 2020

@shihai1991 shihai1991 requested a review from encukou February 25, 2021 16:21
@shihai1991 shihai1991 closed this Feb 26, 2021
@shihai1991 shihai1991 reopened this Feb 26, 2021
@shihai1991 shihai1991 changed the title bpo-42035: Add a PyType_GetName() to get type's name. bpo-42035: Add a PyType_GetName() to get type's short name. Jul 20, 2021
@shihai1991
Copy link
Member Author

Hi, Petr. Do you think this PR is good enough? @encukou

@shihai1991 shihai1991 force-pushed the bpo_42035 branch 2 times, most recently from c7f03cb to de33627 Compare July 20, 2021 16:32
@shihai1991 shihai1991 requested a review from a team as a code owner July 20, 2021 16:32
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
@encukou
Copy link
Member

encukou commented Jul 23, 2021

It's on my review list for Tuesday. Apologies for the delay!

@shihai1991
Copy link
Member Author

It's on my review list for Tuesday. Apologies for the delay!

Get it. Thanks, petr :)

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation & tests look great!
But please, merge in the current main branch add PyType_GetName to stable_abi.txt and regenerate the limited API.
Consider adding PyType_GetQualName as well.

@shihai1991
Copy link
Member Author

shihai1991 commented Jul 27, 2021

But please, merge in the current main branch add PyType_GetName to stable_abi.txt and regenerate the limited API.

Get it.

Consider adding PyType_GetQualName as well.

OK. I will use another PR to do it.

@shihai1991 shihai1991 requested a review from encukou July 27, 2021 16:32
@encukou encukou merged commit a390ebe into python:main Jul 29, 2021
@shihai1991
Copy link
Member Author

Thanks Petr for your review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants