bpo-42006: Stop using PyDict_GetItemString() #23487
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python/initconfig.c
Outdated
| @@ -1050,7 +1050,7 @@ _PyConfig_AsDict(const PyConfig *config) | |||
| static PyObject* | |||
| config_dict_get(PyObject *dict, const char *name) | |||
| { | |||
| PyObject *item = PyDict_GetItemString(dict, name); | |||
| PyObject *item = PyMapping_GetItemString(dict, name); | |||
There was a problem hiding this comment.
PyDict_GetItemString returns a borrowed reference, PyMapping_GetItemString returns an owned reference.
There was a problem hiding this comment.
Thanks for reminding, it has been replaced by PyMapping_GetItemString.
|
There are other issues in this code. See #23488. |
|
Superseded by #23488. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complement to that PR #22648.
https://bugs.python.org/issue42006