-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-31904: support signal module for VxWorks #23391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Misc/NEWS.d/next/VxWorks/README.rst
Outdated
@@ -0,0 +1,3 @@ | |||
Put news entry `blurb`_ files for the *VxWorks* section in this directory. | |||
|
|||
.. _blurb: https://pypi.org/project/blurb/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to not add a new blurb category just for VxWorks. Would you mind to reuse the Library category?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine. Fixed accordingly.
Lib/test/test_signal.py
Outdated
else: | ||
# Start with large chunk size to reduce the | ||
# number of send needed to fill the buffer. | ||
for chunk_size in (2 ** 16, 2 ** 8, 1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to not copy/paste the code, restrict the difference to the loop. Something like:
for chunk_size in (2 ** 16, 2 ** 8, 1): | |
if sys.platform == "vxworks": | |
CHUNK_SIZES = (1,) | |
else: | |
CHUNK_SIZES = (2 ** 16, 2 ** 8, 1) | |
for chunk_size in CHUNK_SIZES: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better solution. Changed.
a716ce3
to
74abc0d
Compare
Merged, thanks. The updated PR is simpler. |
https://bugs.python.org/issue31904