bpo-30727: Fix a race condition in test_threading. #2334
Conversation
|
I would prefer to change the test in the master branch, and backport it later. |
serhiy-storchaka
force-pushed
the
test-notify
branch
from
611193d to
0b141f6
Compare
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
serhiy-storchaka
changed the title
serhiy-storchaka
force-pushed
the
test-notify
branch
from
0b141f6 to
4c51358
Compare
Done. |
pitrou
changed the title
Lib/test/lock_tests.py
Outdated
| # we continue. See issues #8799 and #30727. | ||
| while len(ready) < 5: | ||
| _wait() | ||
| ready = [] |
There was a problem hiding this comment.
I suggest ready.clear() rather than ready=[], just in case.
There was a problem hiding this comment.
Actually this doesn't matter, all workers settle into cond.wait().
(cherry picked from commit 32cb968)
|
GH-2351 is a backport of this pull request to the 3.6 branch. |
(cherry picked from commit 32cb968)
|
GH-2352 is a backport of this pull request to the 3.5 branch. |
…). (cherry picked from commit 32cb968)
|
GH-2353 is a backport of this pull request to the 2.7 branch. |
No description provided.