Skip to content

[3.5] bpo-30500: urllib: Simplify splithost by calling into urlparse. (#1849) #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2017
Merged

[3.5] bpo-30500: urllib: Simplify splithost by calling into urlparse. (#1849) #2290

merged 1 commit into from
Jun 20, 2017

Conversation

vstinner
Copy link
Member

The current regex based splitting produces a wrong result. For example::

http://abc#@def

Web browsers parse that URL as http://abc/#@def, that is, the host
is abc, the path is /, and the fragment is #@def.
(cherry picked from commit 90e01e5)

@postmasters @vstinner
bpo-30500: urllib: Simplify splithost by calling into urlparse. (#1849)
b29865a 
The current regex based splitting produces a wrong result. For example::

  http://abc#@def

Web browsers parse that URL as ``http://abc/#@def``, that is, the host
is ``abc``, the path is ``/``, and the fragment is ``#@def``.
(cherry picked from commit 90e01e5)
@bedevere-bot bedevere-bot mentioned this pull request Jun 20, 2017
Merged
@vstinner vstinner added the type-security A security issue label Jun 20, 2017
@vstinner vstinner merged commit 4899d84 into python:3.5 Jun 20, 2017
@vstinner vstinner deleted the splithost35 branch June 20, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @postmasters