[3.9] Fix bpo-39416: Change "Numeric" to lower case; an english word, not a class name (GH-22867) #22868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class name (pythonGH-22867) This is a trivial fix to [bpo-39416](), which didn't come up until it was already committed ``` Change "Numeric" to "numeric". I believe this is trivial enough to not need an issue or a NEWS entry, although I'm unclear on what branches the original pull request received backports. ``` Automerge-Triggered-By: GH:merwok (cherry picked from commit f8b1ccd) Co-authored-by: kpinc <[email protected]>
|
@kpinc: Status check is done, and it's a success ✅ . |
merwok
approved these changes
Oct 21, 2020
|
@kpinc: Status check is done, and it's a success ✅ . |
|
I stopped the Docs job at 17 minutes, expecting I would have an option to re-start it, but this got the PR merged! Strange CI, will check if the commit on 3.9 branch builds fine. |
|
Damn I also edited the PR description to try to get a better commit message than the one on master, but I guess squashing a 1-commit branch is like a rebase and uses the commit message, which has noise but well 🙁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to bpo-39416
Automerge-Triggered-By: GH:merwok
(cherry picked from commit f8b1ccd)
Co-authored-by: kpinc [email protected]
https://bugs.python.org/issue39416
Automerge-Triggered-By: GH:merwok