-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-41916: allow cross-compiled python to have -pthread set for CXX #22525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some testing indicates that this worked without issues. Given that the tests all seem to pass on CI, I think this is good to go. |
I have confirmed that this does fix the issues I was running into, and my cross compiled packages seem to be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix looks correct. @jaraco could you have a look?
I've been using it to build python 3.9.x and more recently python 3.10.x without any issues. |
Perhaps, just add a news item to make it quicker to merge. I think the code is good, it is just missing a news entry. |
You can use https://blurb-it.herokuapp.com/ to add a news fragment. |
6ff346a
to
0fdc88d
Compare
I'm afraid I don't have a lot of experience with this aspect of CPython. Perhaps @ambv could review or suggest a reviewer? |
FWIW, I've been using the patch to cross-compile python for use in CI since I've made the patch. |
0fdc88d
to
77af732
Compare
Rebased on main; integrated changes that were made in #29485 |
@tiran seems to make a lot of changes to configure.ac, perhaps they might be a better reviewer for this? |
When cross-compiling, the compile/run test for -pthread always fails so -pthread will never be automatically set without an override from the cache. ac_cv_pthread can already be overridden, so do the same thing for ac_cv_cxx_thread.
77af732
to
fefd3d2
Compare
@tiran, do have time to have a quick look at this PR? Thanks! |
IIRC, @gpshead has some interest in cross-compilation and @erlend-aasland has experience with the configure script. |
When cross-compiling, the compile/run test for -pthread always fails so -pthread will never be automatically set without an override from the cache. ac_cv_pthread can already be overridden, so do the same thing for ac_cv_cxx_thread.
I've validated that my cross-compiled python has the variables set now when configured via:
I now get as expected:
I haven't yet checked to see if it all works quite yet, will do later today.
https://bugs.python.org/issue41916