bpo-41073: PyType_GetSlot() could accept static types. #21395

shihai1991 · 2020-07-08T14:09:37Z

https://bugs.python.org/issue41073

shihai1991 · 2020-07-08T15:42:07Z

@vstinner @encukou pls take a look if you have free time, thanks.

encukou

This will not work with static types. Try adding some tests, and look at how PyHeapTypeObject is different from PyTypeObject. You should see why.
Sadly I don't have time right now to go into detail, but I'll be happy to add more later. Let me know if you get stuck.

encukou · 2020-07-08T15:59:57Z

Include/typeslots.h

+#define Py_tp_version_tag 96
+#define Py_tp_weaklist 97
+#define Py_tp_weaklistoffset 98
+#endif


These should not be part of the limited API. See Py_bf_getbuffer above for how to exclude them.

ok, I will update it.

Looks like we juse need define it and it don't need to be excluded, no?

Hi, petr. I create a test module(_testgettypeslots) to see the blocks, but I am not get stuck,: shihai1991#18

Do we need add some special test cases?

Hi, petr. Due to my stupied rebase operation, I decide to create a new PR: #21931

bedevere-bot · 2020-07-08T16:04:48Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

shihai1991 · 2020-07-09T11:30:23Z

This will not work with static types. Try adding some tests, and look at how PyHeapTypeObject is different from PyTypeObject. You should see why.
Sadly I don't have time right now to go into detail, but I'll be happy to add more later. Let me know if you get stuck.

Copy that, Let me try it.

…strings (pythonGH-21369) * Document is_annotate() and update doc strings * Move quotes to the next line. Co-authored-by: Pablo Galindo <[email protected]> Co-authored-by: Pablo Galindo <[email protected]>

…ythonGH-21305)

…() (pythonGH-21385)

…gs() (pythonGH-19378)" (pythonGH-21390) This partially reverts commit 45ec5b9.

@1st1

…onGH-21401) The running loop holder cache variable was always set to NULL when calling set_running_loop. Now set_running_loop saves the newly created running loop holder in the cache variable for faster access in get_running_loop. Automerge-Triggered-By: @1st1

…bject (pythonGH-21240) The issue is triggered by the bytearray() + bytearray() operation. Detected by GCC 10 static analysis tool.

…ing. (pythonGH-20542)

…() (pythonGH-21407)

@ericvsmith

…ation page (pythonGH-21413) Automerge-Triggered-By: @ericvsmith

…21412)

) * Add failing test. * bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN) When gen.throw() is called on a generator after a "yield from", the intermediate stack trace entries are lost. This commit fixes that.

The >>> as the last line serve no purpose and are not colored correctly by Sphinx.

Keywords are present in the main module tab completion lists generated by rlcompleter, which is used by REPLs on *nix. Add all keywords to IDLE's main module name list except those already added from builtins (True, False, and None) . This list may also be used by Show Completions on the Edit menu, and its hot key. Rewrite Completions doc. Co-authored-by: Cheryl Sabella <[email protected]>

* Clarify __deepcopy__ memo dict argument usage * Add full stop

the-knights-who-say-ni · 2020-08-20T17:07:57Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Akuli

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

shihai1991 · 2020-08-20T17:24:04Z

Sorry for my terrible PR~

methane · 2020-08-21T01:23:04Z

"rebase" creates this type of trouble sometime. You can use "merge" instead.
See https://discuss.python.org/t/info-rebase-origin-master-push-f-workflow-corrupts-pull-request-rarely/2558 for detail.

shihai1991 · 2020-08-21T03:02:46Z

"rebase" creates this type of trouble sometime. You can use "merge" instead.
See https://discuss.python.org/t/info-rebase-origin-master-push-f-workflow-corrupts-pull-request-rarely/2558 for detail.

Thanks a million, Inada. It's very useful to me. I haven't found some useful info in google and not sure git merge is a good way to reslove this problem before, Lol~

Akuli · 2020-08-21T08:14:31Z

You might like git lola. I use it a lot and I probably couldn't use git without it. It displays your git history as a nice tree that very clearly shows what's going on with branches and merges.

shihai1991 · 2020-08-21T14:54:30Z

You might like git lola. I use it a lot and I probably couldn't use git without it. It displays your git history as a nice tree that very clearly shows what's going on with branches and merges.

Thanks. I will try to use it ;) The problem in this PR is that I can not easy use git rebase to update the ancestor commit of old feature develop branch.

shihai1991 added 2 commits July 8, 2020 21:10

PyType_GetSlot() could accept static types

2baaf6c

update docs' style

9fb5ed4

the-knights-who-say-ni added the CLA signed label Jul 8, 2020

bedevere-bot added the awaiting review label Jul 8, 2020

encukou requested changes Jul 8, 2020

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Jul 8, 2020

vstinner and others added 20 commits August 21, 2020 01:06

bpo-29778: test_embed tests the path configuration (pythonGH-21306)

ddb08f5

bpo-41224: Document is_annotated() in symtable module and update doc …

72c57f5

…strings (pythonGH-21369) * Document is_annotate() and update doc strings * Move quotes to the next line. Co-authored-by: Pablo Galindo <[email protected]> Co-authored-by: Pablo Galindo <[email protected]>

bpo-41173: Copy test results file from ARM worker before uploading (p…

4f2a589

…ythonGH-21305)

Add a test for get_id() (pythonGH-21370)

4165234

closes bpo-41235: Fix the error handling in SSLContext.load_dh_params…

6e362d8

…() (pythonGH-21385)

Revert "bpo-40170: PyType_HasFeature() now always calls PyType_GetFla…

e4512c0

…gs() (pythonGH-19378)" (pythonGH-21390) This partially reverts commit 45ec5b9.

bpo-41175: Guard against a NULL pointer dereference within bytearrayo…

badce8a

…bject (pythonGH-21240) The issue is triggered by the bytearray() + bytearray() operation. Detected by GCC 10 static analysis tool.

bpo-40597: Allow email.contextmanager set_content() to set a null str…

aee8f10

…ing. (pythonGH-20542)

Doc: Builtins functions: faster jump table (pythonGH-21376)

e8ab709

bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…

e8e8414

…() (pythonGH-21407)

bpo-41199: Docstring convention not followed for dataclasses document…

10ddc13

…ation page (pythonGH-21413) Automerge-Triggered-By: @ericvsmith

bpo-40275: Use new test.support helper submodules in tests (pythonGH-…

d4ae3c0

…21412)

bpo-41172: Fix check for compiler in test suite (pythonGH-21400)

10a0fd6

Remove trailing >>> in enum docs (pythonGH-21358)

ae339e3

The >>> as the last line serve no purpose and are not colored correctly by Sphinx.

bpo-23802: patch: __deepcopy__ memo dict argument usage (pythonGH-21326)

8b69fa9

* Clarify __deepcopy__ memo dict argument usage * Add full stop

bpo-41263: Convert code.__new__ to Argument Clinic (pythonGH-21426)

34e0077

bpo-36346: Do not use legacy Unicode C API in ctypes. (python#21429)

3e15a13

shihai1991 requested review from ericsnowcurrently, ericvsmith, ethanfurman, ezio-melotti, gpshead, gvanrossum, ilevkivskyi, lysnikolaou, methane, ncoghlan, pablogsal, pganssle, rhettinger, skrah, terryjreedy, tiran, vsajip, warsaw and a team as code owners August 20, 2020 17:07

the-knights-who-say-ni removed the CLA signed label Aug 20, 2020

the-knights-who-say-ni added the CLA not signed label Aug 20, 2020

shihai1991 closed this Aug 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-41073: PyType_GetSlot() could accept static types. #21395

bpo-41073: PyType_GetSlot() could accept static types. #21395

shihai1991 commented Jul 8, 2020 •

edited by bedevere-bot

Loading

shihai1991 commented Jul 8, 2020

encukou left a comment

encukou Jul 8, 2020

shihai1991 Jul 9, 2020

shihai1991 Jul 9, 2020

shihai1991 Jul 11, 2020

shihai1991 Aug 20, 2020

bedevere-bot commented Jul 8, 2020

shihai1991 commented Jul 9, 2020

the-knights-who-say-ni commented Aug 20, 2020

shihai1991 commented Aug 20, 2020

methane commented Aug 21, 2020

shihai1991 commented Aug 21, 2020

Akuli commented Aug 21, 2020

shihai1991 commented Aug 21, 2020 •

edited

Loading

bpo-41073: PyType_GetSlot() could accept static types. #21395

bpo-41073: PyType_GetSlot() could accept static types. #21395

Conversation

shihai1991 commented Jul 8, 2020 • edited by bedevere-bot Loading

shihai1991 commented Jul 8, 2020

encukou left a comment

Choose a reason for hiding this comment

encukou Jul 8, 2020

Choose a reason for hiding this comment

shihai1991 Jul 9, 2020

Choose a reason for hiding this comment

shihai1991 Jul 9, 2020

Choose a reason for hiding this comment

shihai1991 Jul 11, 2020

Choose a reason for hiding this comment

shihai1991 Aug 20, 2020

Choose a reason for hiding this comment

bedevere-bot commented Jul 8, 2020

shihai1991 commented Jul 9, 2020

the-knights-who-say-ni commented Aug 20, 2020

CLA Missing

shihai1991 commented Aug 20, 2020

methane commented Aug 21, 2020

shihai1991 commented Aug 21, 2020

Akuli commented Aug 21, 2020

shihai1991 commented Aug 21, 2020 • edited Loading

shihai1991 commented Jul 8, 2020 •

edited by bedevere-bot

Loading

shihai1991 commented Aug 21, 2020 •

edited

Loading