bpo-41173: Copy test results file from ARM worker before uploading #21305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
added
OS-windows
skip news
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
paulmon
reviewed
Jul 6, 2020
| set ERR=%ERRORLEVEL% | ||
| echo where scp | ||
| where scp | ||
| echo scp %SSH_SERVER%:"%REMOTE_PYTHON_DIR%test-results.xml" "%PYTHON_SOURCE%\test-results.xml" | ||
| scp %SSH_SERVER%:"%REMOTE_PYTHON_DIR%test-results.xml" "%PYTHON_SOURCE%\test-results.xml" |
There was a problem hiding this comment.
"%PYTHON_SOURCE%\test-results.xml" should be "%PYTHON_SOURCE%test-results.xml"
I don't know if the extra slash will matter to scp or not without testing.
paulmon
reviewed
Jul 7, 2020
Tools/buildbot/test.bat
Outdated
| @@ -37,7 +37,12 @@ set TEMP_ARGS=--temp %REMOTE_PYTHON_DIR%temp | |||
|
|
|||
| set rt_args=%rt_opts% %dashU% -rwW --slowest --timeout=1200 --fail-env-changed %regrtest_args% %TEMP_ARGS% | |||
| ssh %SSH_SERVER% "set TEMP=%REMOTE_PYTHON_DIR%temp& %REMOTE_PYTHON_DIR%PCbuild\rt.bat" %rt_args% | |||
There was a problem hiding this comment.
Maybe change this to
ssh %SSH_SERVER% "set TEMP=%REMOTE_PYTHON_DIR%temp & cd %REMOTE_PYTHON_DIR% & PCbuild\rt.bat" %rt_args%
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 7, 2020
…ythonGH-21305) (cherry picked from commit 10772ec) Co-authored-by: Steve Dower <[email protected]>
|
GH-21382 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 7, 2020
…H-21305) (cherry picked from commit 10772ec) Co-authored-by: Steve Dower <[email protected]>
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41173