bpo-39960: Allow heap types in the "Carlo Verre" hack check that override "tp_setattro()" #21092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ride "tp_setattro()".
gvanrossum
approved these changes
Jul 2, 2020
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM except for one nit. I will apply that and land. Thanks!
Contributor
|
@scoder: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @scoder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 3, 2020
…ride "tp_setattro()" (pythonGH-21092) Automerge-Triggered-By: @gvanrossum (cherry picked from commit 148f329) Co-authored-by: scoder <[email protected]>
|
GH-21288 is a backport of this pull request to the 3.9 branch. |
Contributor
|
Sorry, @scoder, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Jul 3, 2020
…ride "tp_setattro()" (GH-21092) Automerge-Triggered-By: @gvanrossum (cherry picked from commit 148f329) Co-authored-by: scoder <[email protected]>
scoder
added a commit
to scoder/cpython
that referenced
this pull request
Jul 5, 2020
…ride "tp_setattro()" (pythonGH-21092) Backport to Py3.8.
|
GH-21339 is a backport of this pull request to the 3.8 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39960
Automerge-Triggered-By: @gvanrossum