bpo-40650: Include winsock2.h in pytime.c, instead of a full windows.h #20137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
added
DO-NOT-MERGE
needs backport to 3.7
OS-windows
and removed
DO-NOT-MERGE
labels
|
Thanks @gongminmin for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 18, 2020
pythonGH-20137) (cherry picked from commit f660567) Co-authored-by: Minmin Gong <[email protected]>
|
GH-20187 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 18, 2020
pythonGH-20137) (cherry picked from commit f660567) Co-authored-by: Minmin Gong <[email protected]>
|
GH-20188 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
May 18, 2020
GH-20137) (cherry picked from commit f660567) Co-authored-by: Minmin Gong <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 18, 2020
GH-20137) (cherry picked from commit f660567) Co-authored-by: Minmin Gong <[email protected]>
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python/pytime.c only needs struct timeval from windows.h. It can be changed to winsock2.h for better compiling performance. Picking winsock2.h instead of winsock.h is because the 2 version works with desktop apps and UWP apps.
https://bugs.python.org/issue40650