Skip to content

bpo-2716: add license for audioop module #19972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 21, 2022
Merged

bpo-2716: add license for audioop module #19972

merged 7 commits into from
Oct 21, 2022

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented May 6, 2020 •
edited
Loading

remilapeyre
remilapeyre suggested changes May 7, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @furkanonder, I think the bpo issue for this PR is bpo-2716, not bpo-40462.

@furkanonder furkanonder changed the title bpo-40462: add license for audioop module bpo-2716: add license for audioop module May 7, 2020
@vstinner
Copy link
Member

vstinner commented May 7, 2020

The audioop module uses the code base in g771.c file of the SoX project

Which functions were created from SoX code? All of them? Some of them?

@furkanonder
Copy link
Contributor Author

The audioop module uses the code base in g771.c file of the SoX project

Which functions were created from SoX code? All of them? Some of them?

Some of functions,globals variables and array declarations.

@AlexWaygood
Copy link
Member

I'm not sure if this PR (and the associated issue) is still relevant now that audioop has been deprecated following the acceptance of PEP 594. @brettcannon, what do you think?

@arhadthedev
Copy link
Member

@AlexWaygood I'm not a core dev but corporate legal matters is not a joke. They need to be taken seriously to avoid any potential problem from Oracle that now owns all Sun's intellectual property. So in my opinion not only this should be merged, it also should be backported as far as possible.

@hugovk
Copy link
Member

hugovk commented Apr 11, 2022

Associated issue: https://bugs.python.org/issue2716 -> #46968

@brettcannon
Copy link
Member

@VanL does this change look good?

@VanL
Copy link
Member

VanL commented Apr 11, 2022 •
edited
Loading

This license does not match the declared license from the source file (GPL, or possible LGPL later). After looking at all the declared tags, they all are consistently under *GPL licenses. So I would not merge this:
-The license looks incorrect

  • Given the apparent license, it would significantly affect the licensing of Python overall

Update: I see the link to sourcearchive on bpo, but I can't verify the license because that is now down. The sourcearchive license would be compatible with Python's licensing, but the link to sourceforge (which the new patch references) declares this to be under the GPL.

If you can update this to use the source from https://web.archive.org/web/19970716121258/http://www.spies.com/Sox/Archive/soxgamma.tar.gz, that has a license that could be compatible (with appropriate copying of all copyright information), but I would not merge this as-is. In fact, I would suggest pulling out this module/rewriting this bit.

brettcannon
brettcannon requested changes Apr 12, 2022
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per Van's suggestion.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label May 11, 2022
@AA-Turner
Copy link
Member

Triggering CLA.

A

@furkanonder furkanonder requested review from brettcannon and remilapeyre and removed request for brettcannon October 3, 2022 19:46
@furkanonder
Copy link
Contributor Author

This license does not match the declared license from the source file (GPL, or possible LGPL later). After looking at all the declared tags, they all are consistently under *GPL licenses. So I would not merge this: -The license looks incorrect

* Given the apparent license, it would significantly affect the licensing of Python overall

Update: I see the link to sourcearchive on bpo, but I can't verify the license because that is now down. The sourcearchive license would be compatible with Python's licensing, but the link to sourceforge (which the new patch references) declares this to be under the GPL.

If you can update this to use the source from https://web.archive.org/web/19970716121258/http://www.spies.com/Sox/Archive/soxgamma.tar.gz, that has a license that could be compatible (with appropriate copying of all copyright information), but I would not merge this as-is. In fact, I would suggest pulling out this module/rewriting this bit.

@VanL @brettcannon I have added the license in the source you mentioned.

@brettcannon brettcannon requested review from brettcannon and removed request for remilapeyre October 5, 2022 21:16
@furkanonder furkanonder requested review from remilapeyre and brettcannon and removed request for brettcannon and remilapeyre October 6, 2022 07:05
@brettcannon brettcannon merged commit 4c1145b into python:main Oct 21, 2022
@miss-islington
Copy link
Contributor

Thanks @furkanonder for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2022
@furkanonder @miss-islington
bpo-2716: add license for audioop module (pythonGH-19972)
4d2190b 
(cherry picked from commit 4c1145b)

Co-authored-by: Furkan Onder <[email protected]>
@bedevere-bot
Copy link

GH-98531 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 21, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2022
@furkanonder @miss-islington
bpo-2716: add license for audioop module (pythonGH-19972)
a72d331 
(cherry picked from commit 4c1145b)

Co-authored-by: Furkan Onder <[email protected]>
@bedevere-bot
Copy link

GH-98532 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 21, 2022
@brettcannon brettcannon mentioned this pull request Oct 21, 2022
Closed
miss-islington added a commit that referenced this pull request Oct 21, 2022
@miss-islington @furkanonder
bpo-2716: add license for audioop module (GH-19972)
68f25e2 
(cherry picked from commit 4c1145b)

Co-authored-by: Furkan Onder <[email protected]>
ambv pushed a commit that referenced this pull request Oct 28, 2022
@miss-islington @furkanonder
[3.10] bpo-2716: add license for audioop module (GH-19972) (#98532)
586bb1f 
bpo-2716: add license for audioop module (GH-19972)
(cherry picked from commit 4c1145b)

Co-authored-by: Furkan Onder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remilapeyre remilapeyre remilapeyre requested changes

@brettcannon brettcannon brettcannon approved these changes

@cinarizasyon cinarizasyon cinarizasyon approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.