Skip to content

bpo-40489: Add test case for dict contain use after free #19906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2020
Merged

bpo-40489: Add test case for dict contain use after free #19906

merged 2 commits into from
May 4, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented May 4, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 4, 2020
@corona10 corona10 requested a review from serhiy-storchaka May 4, 2020 16:42
@corona10 corona10 requested a review from rhettinger May 4, 2020 16:43
remilapeyre
remilapeyre reviewed May 4, 2020
View reviewed changes
@corona10
Update Lib/test/test_dict.py
f96608a 
Co-authored-by: Rémi Lapeyre <[email protected]>
remilapeyre
remilapeyre approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried removing the Py_INCREF in lookdict() and this test work to expose the segfault :)

@corona10
Copy link
Member Author

corona10 commented May 4, 2020

@rhettinger Thank you for the review :)

@corona10 corona10 self-assigned this May 4, 2020
@corona10 corona10 merged commit 785f5e6 into python:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

+1 more reviewer

@remilapeyre remilapeyre remilapeyre approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@corona10 corona10

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @rhettinger @remilapeyre @the-knights-who-say-ni @bedevere-bot