bpo-31904: Increase LOOPBACK_TIMEOUT to 10 for VxWorks RTOS #19447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimJJewett
reviewed
Jul 27, 2020
There was a problem hiding this comment.
It looks a bit odd to see:
LOOPBACK_TIMEOUT = 10
elif sys.platform == 'vxworks':
LOOPBACK_TIMEOUT = 10
but I suppose adding an OR after the existing AND condition would also be awkward. I'll leave it to your (or someone else's) judgment.
(Especially) if you are going to keep it a separate clause, I would like to see a comment explaining why. For instance, "vxworks is used on embedded devices, and some boards are quite slow; avoid false alarms"
|
Two comments, but it is possible they will lead to no change, and likely they will lead to nothing bigger than a comment. Consider this a positive review for triage/commit purposes. |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 4, 2020
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VxWorks might run on some low-performance board. If TLS is enabled with ftp, it needs bigger LOOPBACK_TIMEOUT value. Otherwise, some test cases under test.test_ftplib.TestTLS_FTPClassMixin will fail. The value 10 is enough to prevent test failure.
https://bugs.python.org/issue31904