bpo-39943: Keep constness of pointers. #19210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make two pointers be const char *. This quiets a warning from -Wincompatible-pointer-types.
|
You can add |
I'm glad to do that. I was trying to keep changes minimal, but I'll resubmit. |
| @@ -1598,7 +1598,7 @@ PyMarshal_WriteObjectToString(PyObject *x, int version) | |||
| w_object(x, &wf); | |||
| w_clear_refs(&wf); | |||
| if (wf.str != NULL) { | |||
| char *base = PyBytes_AS_STRING((PyBytesObject *)wf.str); | |||
| const char *base = PyBytes_AS_STRING((PyBytesObject *)wf.str); | |||
| if (wf.ptr - base > PY_SSIZE_T_MAX) { | |||
There was a problem hiding this comment.
It seems to me, that this condition is always false (see w_reserve()). So you can remove it.
| @@ -1598,7 +1598,7 @@ PyMarshal_WriteObjectToString(PyObject *x, int version) | |||
| w_object(x, &wf); | |||
| w_clear_refs(&wf); | |||
| if (wf.str != NULL) { | |||
| char *base = PyBytes_AS_STRING((PyBytesObject *)wf.str); | |||
There was a problem hiding this comment.
AFAIK the cast to PyBytesObject * is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39943