Skip to content

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Mar 16, 2020

Copy link
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@furkanonder furkanonder requested a review from isidentical March 16, 2020 09:51
Co-Authored-By: Batuhan Taşkaya <[email protected]>
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also my comment on the issue.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@furkanonder furkanonder requested a review from zware March 17, 2020 23:17
@furkanonder
Copy link
Contributor Author

It was combined with another pr. => #19006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants