Skip to content

Fix ast.rst demo code #18916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix ast.rst demo code #18916

wants to merge 1 commit into from

Conversation

clumsyme
Copy link

Missing copy_location in demo code.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@clumsyme

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@tirkarthi
Copy link
Member

The change was done in #17172 cc: @pablogsal @isidentical

@clumsyme clumsyme closed this Mar 11, 2020
@clumsyme clumsyme reopened this Mar 11, 2020
@isidentical
Copy link
Member

I don't get why you closed and re-opened this PR? Is that a mistake or you want this version to be reviewed?

@clumsyme
Copy link
Author

I don't get why you closed and re-opened this PR? Is that a mistake or you want this version to be reviewed?

Sorry I didn't read tirkarthi's comment clearly and mistakenly thought the correction was done in pr17172.

@isidentical
Copy link
Member

Did you read the issue about why this 'copy_locations' removed in the first place?

@clumsyme
Copy link
Author

Did you read the issue about why this 'copy_locations' removed in the first place?

OK, I see. I'm closing this.

But there's two issues after removing copy_locations:

  1. Syntax error in last line of code:
class RewriteName(NodeTransformer):

    def visit_Name(self, node):
        return Subscript(
            value=Name(id='data', ctx=Load()),
            slice=Index(value=Constant(value=node.id)),
            ctx=node.ctx
        ), node)
  1. Inconsistent with the docstring in ast.py

@clumsyme clumsyme closed this Mar 11, 2020
@pablogsal
Copy link
Member

@clumsyme Thanks for reporting those. Opened #18946 to fix them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants