Skip to content

bpo-3530: Use fix_missing_locations when node transformer adds nodes #17172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 12, 2020

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Nov 15, 2019

Remove misleading (inadequate) suggestion from example.

https://bugs.python.org/issue3530

Automerge-Triggered-By: @pablogsal

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 15, 2019
@terryjreedy terryjreedy changed the title bpo-3530: advice fix_missing_locations usage on new node introduction bpo-3530: use fix_missing_locations when adding nodes Nov 17, 2019
@terryjreedy terryjreedy changed the title bpo-3530: use fix_missing_locations when adding nodes bpo-3530: Use fix_missing_locations when node transformer adds nodes Nov 17, 2019
@terryjreedy
Copy link
Member

@isidentical Please add news item with blurb or blurb-it(sp?). Suggestion:
In ast doc, fix misleading NodeTransformer example and add fix_missing_locations advice.

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work! 🎉

@pablogsal pablogsal merged commit 6680f4a into python:master Jan 12, 2020
@miss-islington
Copy link
Contributor

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2020
…n the AST docs (pythonGH-17172)

Co-authored-by: Pablo Galindo <[email protected]>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <[email protected]>
@bedevere-bot
Copy link

GH-17972 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2020
…n the AST docs (pythonGH-17172)

Co-authored-by: Pablo Galindo <[email protected]>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <[email protected]>
@bedevere-bot
Copy link

GH-17973 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jan 12, 2020
…n the AST docs (GH-17172)

Co-authored-by: Pablo Galindo <[email protected]>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <[email protected]>
miss-islington added a commit that referenced this pull request Jan 12, 2020
…n the AST docs (GH-17172)

Co-authored-by: Pablo Galindo <[email protected]>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants