bpo-39763: Refactor setup.py #18778
Merged
bpo-39763: Refactor setup.py #18778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split long build_extensions() method into sub-methods. Fix also a typo in Popen.wait(): replace sts with status.
|
With this refactoring, it may become easier to change in which order extensions are built, to try to build the subprocess earlier. Maybe we could try to build the subprocess first, not in parallel, then reload the subprocess module to build next extensions with the newly built subprocess module. Another approach is to run setup.py twice. Once to build the subprocess module, a second time to build all other modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split long build_extensions() method into sub-methods.
Fix also a typo in Popen.wait(): replace sts with status.
https://bugs.python.org/issue39763