Skip to content

bpo-38870: Simplify tuple like interleaves, roundtrip extslice properly #17892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2020
Merged

bpo-38870: Simplify tuple like interleaves, roundtrip extslice properly #17892

merged 1 commit into from
Mar 9, 2020

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Jan 7, 2020 •
edited by bedevere-bot
Loading

pablogsal
pablogsal reviewed Jan 7, 2020
View reviewed changes
@isidentical isidentical requested a review from pablogsal January 7, 2020 11:38
pablogsal
pablogsal reviewed Jan 7, 2020
View reviewed changes
@isidentical
Copy link
Member Author

Thanks for the suggestions @pablogsal!

@isidentical isidentical requested a review from pablogsal January 7, 2020 12:11
pablogsal
pablogsal reviewed Jan 7, 2020
View reviewed changes
@pablogsal
Copy link
Member

pablogsal commented Jan 7, 2020 •
edited
Loading

The build is failing because you have trailing whitespace (you can run make patchcheck to make the fixes).

@isidentical
Copy link
Member Author

isidentical commented Mar 8, 2020 •
edited
Loading

Already fixed on the master with GH-18824

@isidentical isidentical closed this Mar 8, 2020
@isidentical
Copy link
Member Author

Actually we can still apply this simplification

@isidentical isidentical reopened this Mar 8, 2020
@isidentical isidentical force-pushed the bpo-38870-ext-slice branch from d78d34f to 6715561 Compare March 8, 2020 11:15
gvanrossum
gvanrossum approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good.

@isidentical isidentical force-pushed the bpo-38870-ext-slice branch from 6715561 to 967c4cc Compare March 9, 2020 19:05
@gvanrossum gvanrossum mentioned this pull request Mar 9, 2020
Merged
pablogsal
pablogsal reviewed Mar 9, 2020
View reviewed changes
@isidentical isidentical force-pushed the bpo-38870-ext-slice branch from 967c4cc to a7a228d Compare March 9, 2020 19:54
@isidentical isidentical requested a review from pablogsal March 9, 2020 19:54
@pablogsal pablogsal merged commit e7cab7f into python:master Mar 9, 2020
colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
@isidentical @colesbury
bpo-38870: Simplify sequence interleaves in ast.unparse (GH-17892)
8bf4e55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@pablogsal pablogsal pablogsal approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isidentical @pablogsal @gvanrossum @the-knights-who-say-ni @bedevere-bot