Skip to content

bpo-1635741: Remove redundant _Py_INC_TPALLOCS in _Py_NewReference() #17883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-1635741: Remove redundant _Py_INC_TPALLOCS in _Py_NewReference() #17883

wants to merge 1 commit into from

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Jan 7, 2020 •
edited by bedevere-bot
Loading

@shihai1991
Copy link
Member Author

shihai1991 commented Jan 7, 2020 •
edited
Loading

Check test_asyncio test case's failure:

(Pdb) gettotalrefcount()
-7737240
(Pdb) refs_before
-7709437
(Pdb) gettotalrefcount()-refs_before
-28019

in master branch:

(Pdb) gettotalrefcount()
505358
(Pdb) refs_before
497062
(Pdb) gettotalrefcount()-refs_before
8297

Looks like that _Py_INC_TPALLOCS in _Py_NewReference() and this PR should be closed.
Compare to _Py_ForgetReference(), I don't know why _Py_NewReference() need _Py_INC_TPALLOCS. Do you know the reason? @vstinner

@shihai1991 shihai1991 closed this Jan 7, 2020
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shihai1991 @the-knights-who-say-ni @bedevere-bot