Skip to content

bpo-38979: fix ContextVar "__class_getitem__" method #17497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 8, 2019
Merged

bpo-38979: fix ContextVar "__class_getitem__" method #17497

merged 7 commits into from
Dec 8, 2019

Conversation

amiremohamadi
Copy link
Contributor

@amiremohamadi amiremohamadi commented Dec 7, 2019 •
edited by miss-islington
Loading

now contextvars.ContextVar "class_getitem" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov

@amiremohamadi amiremohamadi requested a review from 1st1 as a code owner December 7, 2019 13:10
isidentical
isidentical reviewed Dec 7, 2019
View reviewed changes
Misc/NEWS.d/next/Library/2019-12-07-16-32-42.bpo-38979.q0sIHy.rst Outdated
@@ -0,0 +1,3 @@
return class from __class_getitem__ to simplify subclassing. E.g. `clss =
contextvars.ContextVar[str]` returned `None` instead of `<class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO there is no need for examples for this fix

@isidentical
Copy link
Member

cpython/Lib/test/test_context.py

Lines 41 to 42 in 26ab478

def test_context_var_new_2(self):
self.assertIsNone(contextvars.ContextVar[int])

You need to remove this test

isidentical
isidentical reviewed Dec 7, 2019
View reviewed changes
Misc/NEWS.d/next/Library/2019-12-07-16-32-42.bpo-38979.q0sIHy.rst Outdated
@@ -0,0 +1,3 @@
return class from __class_getitem__ to simplify subclassing. E.g. `clss =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to use double backtick for __class_getitem__

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both @isidentical comments. @amiremohamadi please address them.
Otherwise, the PR looks awesome.

asvetlov
asvetlov requested changes Dec 7, 2019
View reviewed changes
Misc/NEWS.d/next/Library/2019-12-07-16-32-42.bpo-38979.q0sIHy.rst Outdated
@@ -0,0 +1,3 @@
return class from __class_getitem__ to simplify subclassing. E.g. `clss =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both @isidentical comments. @amiremohamadi please address them.
Otherwise, the PR looks awesome.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@asvetlov
Copy link
Contributor

asvetlov commented Dec 7, 2019 •
edited
Loading

Since __class_getitem__ was here starting from Python 3.7 I think that the backport of the fix makes sense.

It cannot break any code.

@amiremohamadi
Copy link
Contributor Author

@asvetlov, @isidentical thanks for your help! :)
I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from asvetlov December 7, 2019 16:44
isidentical
isidentical reviewed Dec 7, 2019
View reviewed changes
@miss-islington
Copy link
Contributor

@amiremohamadi: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 28c9163 into python:master Dec 8, 2019
@miss-islington
Copy link
Contributor

Thanks @amiremohamadi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2019
@amiremohamadi @miss-islington
bpo-38979: fix ContextVar "__class_getitem__" method (pythonGH-17497)
ae7ba6f 
now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <[email protected]>
@bedevere-bot
Copy link

GH-17505 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-17506 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2019
@amiremohamadi @miss-islington
bpo-38979: fix ContextVar "__class_getitem__" method (pythonGH-17497)
2a12f5f 
now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <[email protected]>
miss-islington added a commit that referenced this pull request Dec 8, 2019
@miss-islington @amiremohamadi
bpo-38979: fix ContextVar "__class_getitem__" method (GH-17497)
9baa870 
now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <[email protected]>
@miss-islington
Copy link
Contributor

Thanks @amiremohamadi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17507 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2019
@amiremohamadi @miss-islington
bpo-38979: fix ContextVar "__class_getitem__" method (pythonGH-17497)
8bc865e 
now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <[email protected]>
miss-islington added a commit that referenced this pull request Dec 8, 2019
@miss-islington @amiremohamadi
bpo-38979: fix ContextVar "__class_getitem__" method (GH-17497)
960fca1 
now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@amiremohamadi @shihai1991
bpo-38979: fix ContextVar "__class_getitem__" method (pythonGH-17497)
ab3d109 
now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None. 


https://bugs.python.org/issue38979



Automerge-Triggered-By: @asvetlov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@isidentical isidentical isidentical approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amiremohamadi @isidentical @bedevere-bot @asvetlov @miss-islington @the-knights-who-say-ni