Skip to content

bpo-38916: array.array: remove fromstring() and tostring() #17487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Dec 9, 2019
Merged

bpo-38916: array.array: remove fromstring() and tostring() #17487

vstinner merged 1 commit into from
Dec 9, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 6, 2019 •
edited by bedevere-bot
Loading

`array.array: Remove tostring() and fromstring() methods. They were
aliases to tobytes() and frombytes(), deprecated since Python 3.2.

https://bugs.python.org/issue38916

@vstinner
bpo-38916: array.array: remove fromstring() and tostring()
48ea3f9 
`array.array: Remove tostring() and fromstring() methods.  They were
aliases to tobytes() and frombytes(), deprecated since Python 3.2.
@vstinner
Copy link
Member Author

vstinner commented Dec 6, 2019

cc @corona10 @rhettinger @brettcannon

@vstinner
Copy link
Member Author

vstinner commented Dec 6, 2019

I kept these notes in the array.rst documentation, since they help to migrate from Python 2 to Python 3:

   .. versionadded:: 3.2
      :meth:`tostring` is renamed to :meth:`tobytes` for clarity.

and

   .. versionadded:: 3.2
      :meth:`fromstring` is renamed to :meth:`frombytes` for clarity.

@vstinner
Copy link
Member Author

vstinner commented Dec 6, 2019

Note for myself: oops, there is a typo in the commit message, remove >`<.

corona10
corona10 approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me :)

@vstinner vstinner merged commit 0131aba into python:master Dec 9, 2019
@vstinner vstinner deleted the array branch December 9, 2019 13:09
@vstinner
Copy link
Member Author

vstinner commented Dec 9, 2019

Thanks for the review @corona10.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vstinner @shihai1991
bpo-38916: array.array: remove fromstring() and tostring() (pythonGH-…
bd7a6a3 
…17487)

array.array: Remove tostring() and fromstring() methods.  They were
aliases to tobytes() and frombytes(), deprecated since Python 3.2.
@tirkarthi tirkarthi mentioned this pull request Feb 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @corona10 @the-knights-who-say-ni @bedevere-bot