Skip to content

Update the URL for the requests package #17006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2019
Merged

Update the URL for the requests package #17006

merged 3 commits into from
Oct 31, 2019

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Oct 30, 2019 •
edited by miss-islington
Loading

Change the url from docs.python-requests.org to requests.readthedocs.io

Automerge-Triggered-By: @Mariatta

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@simon04

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 30, 2019
brandtbucher
brandtbucher approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time @simon04, and welcome to CPython! 😎

Looks good to me.

Mariatta
Mariatta reviewed Oct 30, 2019
View reviewed changes
Mariatta
Mariatta requested changes Oct 30, 2019
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, however the right url is https://requests.readthedocs.io/en/master/

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@simon04
Copy link
Contributor Author

simon04 commented Oct 31, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@Mariatta: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from Mariatta October 31, 2019 06:59
@Mariatta Mariatta changed the title doc(http.client): fix link for requests package Update the URL for the requests package Oct 31, 2019
@miss-islington miss-islington merged commit 112f2b8 into python:master Oct 31, 2019
@miss-islington
Copy link
Contributor

Thanks @simon04 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @simon04 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2019
@simon04 @miss-islington
Update the URL for the requests package (pythonGH-17006)
537ebff 
Change the url from docs.python-requests.org to requests.readthedocs.io
(cherry picked from commit 112f2b8)

Co-authored-by: Simon Legner <[email protected]>
@bedevere-bot
Copy link

GH-17014 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2019
@simon04 @miss-islington
Update the URL for the requests package (pythonGH-17006)
ff2ec94 
Change the url from docs.python-requests.org to requests.readthedocs.io
(cherry picked from commit 112f2b8)

Co-authored-by: Simon Legner <[email protected]>
@bedevere-bot
Copy link

GH-17015 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 31, 2019
@miss-islington @simon04
Update the URL for the requests package (GH-17006)
f3aa1dc 
Change the url from docs.python-requests.org to requests.readthedocs.io
(cherry picked from commit 112f2b8)

Co-authored-by: Simon Legner <[email protected]>
miss-islington added a commit that referenced this pull request Oct 31, 2019
@miss-islington @simon04
Update the URL for the requests package (GH-17006)
2ed52b8 
Change the url from docs.python-requests.org to requests.readthedocs.io
(cherry picked from commit 112f2b8)

Co-authored-by: Simon Legner <[email protected]>
@brandtbucher
Copy link
Member

Congrats on your first CPython contribution @simon04! 🍾

Looking forward to seeing more from you in the future.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@simon04
Update the URL for the requests package (pythonGH-17006)
aaca9ca 
Change the url from docs.python-requests.org to requests.readthedocs.io
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@simon04 @shihai1991
Update the URL for the requests package (pythonGH-17006)
28cc7d1 
Change the url from docs.python-requests.org to requests.readthedocs.io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simon04 @the-knights-who-say-ni @bedevere-bot @miss-islington @brandtbucher @Mariatta