Skip to content

bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs (GH-15522)" #16724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2019
Merged

bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs (GH-15522)" #16724

merged 2 commits into from
Oct 12, 2019

Conversation

maxking
Copy link
Contributor

@maxking maxking commented Oct 12, 2019 •
edited by miss-islington
Loading

This reverts commit 87bd207.

https://bugs.python.org/issue38449

Automerge-Triggered-By: @maxking

@maxking maxking requested a review from a team as a code owner October 12, 2019 00:42
yarikoptic
yarikoptic reviewed Oct 12, 2019
View reviewed changes
Copy link

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a unit test been added to verify (current and future) correct operation on a file name with ; and may be other tricky symbols legit to be in a file name but not a URL?

@maxking
Copy link
Contributor Author

maxking commented Oct 12, 2019 •
edited by bedevere-bot
Loading

@yarikoptic This is just reverting the previous change which caused the regression so release managers can pick this up for the final releases.

Fixes and more unit tests should be best added in the next PR which should fix the original issue and the issue raised in bpo-38449.

ned-deily
ned-deily requested changes Oct 12, 2019
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except it needs a news (blurb) entry about the revert since it introduces a change between 3.8.0rc1/3.7.5rc1 and 3.8.0final/3.7.5final.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@maxking
Copy link
Contributor Author

maxking commented Oct 12, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@miss-islington miss-islington merged commit 19a3d87 into python:master Oct 12, 2019
@miss-islington
Copy link
Contributor

Thanks @maxking for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @maxking, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 19a3d873005e5730eeabdc394c961e93f2ec02f0 3.8

@maxking maxking deleted the bpo-38449 branch October 12, 2019 05:41
@miss-islington miss-islington self-assigned this Oct 12, 2019
@bedevere-bot
Copy link

GH-16725 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2019
@maxking @miss-islington
bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow op…
badbe63 
…er parsing of URLs (pythonGH-15522)" (pythonGH-16724)

This reverts commit 87bd207.

https://bugs.python.org/issue38449
(cherry picked from commit 19a3d87)

Co-authored-by: Abhilash Raj <[email protected]>
maxking added a commit to maxking/cpython-1 that referenced this pull request Oct 12, 2019
@maxking
[3.8] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to al…
b4a84d0 
…low oper parsing of URLs (pythonGH-15522)" (pythonGH-16724)

This reverts commit 87bd207.

https://bugs.python.org/issue38449
(cherry picked from commit 19a3d87)

Co-authored-by: Abhilash Raj <[email protected]>
@bedevere-bot
Copy link

GH-16728 is a backport of this pull request to the 3.8 branch.

maxking added a commit that referenced this pull request Oct 12, 2019
@maxking
[3.8] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to al…
5a638a8 
…low oper parsing of URLs" (GH-16724) (GH-16728)

This reverts commit 87bd207.

The reason for revert is a regression caused by the change in 3.8.0rc1, see bpo-38449 for more details.

https://bugs.python.org/issue38449
(cherry picked from commit 19a3d87)

Co-authored-by: Abhilash Raj <[email protected]>
miss-islington pushed a commit that referenced this pull request Oct 12, 2019
@maxking @miss-islington
[3.7] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to al…
164bee2 
…low oper parsing of URLs (GH-15685)" (GH-16724) (GH-16727)

Reverts GH-15687 which caused the issue.


https://bugs.python.org/issue22347

https://bugs.python.org/issue38449
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Oct 14, 2019
@maxking @ned-deily
[3.7] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to al…
2a40559 
…low oper parsing of URLs (pythonGH-15685)" (pythonGH-16724) (pythonGH-16727)

Reverts pythonGH-15687 which caused the issue.


https://bugs.python.org/issue22347

https://bugs.python.org/issue38449
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@maxking
bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow op…
550a748 
…er parsing of URLs (pythonGH-15522)" (pythonGH-16724)

This reverts commit 87bd207.



https://bugs.python.org/issue38449
@vadmium vadmium mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

+1 more reviewer

@yarikoptic yarikoptic yarikoptic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maxking @bedevere-bot @miss-islington @yarikoptic @ned-deily @the-knights-who-say-ni