[3.8] bpo-38242: Revert "bpo-36889: Merge asyncio streams (GH-13251)" (#16482) #16485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
changed the title
aeros
reviewed
Sep 30, 2019
| # Yield to the event loop so connection_lost() may be | ||
| # called. Without this, _drain_helper() would return | ||
| # immediately, and code that calls | ||
| # write(...); await drain() | ||
| # in a loop would never call connection_lost(), so it | ||
| # would not see an error when the socket is closed. | ||
| await tasks.sleep(0, loop=self._loop) | ||
| await sleep(0) |
There was a problem hiding this comment.
Same as 3.9 PR.
Suggested change
| await sleep(0) | |
| # Yield to the event loop so connection_lost() may be | |
| # called. Without this, _drain_helper() would return | |
| # immediately, and code that calls | |
| # write(...); await drain() | |
| # in a loop would never call connection_lost(), so it | |
| # would not see an error when the socket is closed. | |
| await tasks.sleep(0, loop=self._loop) |
There was a problem hiding this comment.
I've actually merged the comment, but the await sleep(0) line is correct.
There was a problem hiding this comment.
but the await sleep(0) line is correct
Oh you're right, there's no reason to explicitly pass the loop argument there, that wasn't intentional.
|
@1st1: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.python.org/issue38242 for more details
https://bugs.python.org/issue38242