Skip to content

Conversation

robertpro
Copy link
Contributor

@robertpro robertpro commented Sep 15, 2019

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@robertpro

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@robertpro robertpro changed the title [2to3] Added getproxies to urllib fixes #38080 [2to3] Added getproxies to urllib fixes Sep 15, 2019
@robertpro robertpro changed the title #38080 [2to3] Added getproxies to urllib fixes bpo-38080 [2to3] Added getproxies to urllib fixes Sep 15, 2019
@robertpro robertpro changed the title bpo-38080 [2to3] Added getproxies to urllib fixes bpo-38080 [2to3] Added getproxies to urllib fixes skip news Sep 15, 2019
@robertpro robertpro changed the title bpo-38080 [2to3] Added getproxies to urllib fixes skip news bpo-38080 [2to3] Added getproxies to urllib fixes Sep 15, 2019
@robertpro
Copy link
Contributor Author

robertpro commented Sep 16, 2019

This is my testing code

# some_file.py
import urllib.getproxies

print "Hello world!"

After running ./python ./Tools/scripts/2to3 some_file.py -w

from urllib.request import getproxies

print("Hello world!")

I also signed CLA document :)

@tirkarthi
Copy link
Member

Please add a NEWS entry : https://devguide.python.org/committing/?highlight=news#what-s-new-and-news-entries . The test looks good to me and the addition seems to be a simple fix too. Thanks.

@robertpro
Copy link
Contributor Author

@tirkarthi I was not able to run make html command, it failed on my computer...

I followed the instructions, and looked good, please correct me if I am wrong

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also revert this whitespace change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tirkarthi Done!

Comment on lines 1 to 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Added support to fix ``getproxies`` in the :mod:`lib2to3.fixes.fix_urllib`.
module. Patch by José Roberto Meza Cabrera.
Added support to fix ``getproxies`` in the :mod:`lib2to3.fixes.fix_urllib`
module. Patch by José Roberto Meza Cabrera.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, Done!

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertpro There is an extra "." that should not be there.

Otherwise LGTM

@pablogsal pablogsal merged commit 276a84a into python:master Mar 11, 2020
@pablogsal
Copy link
Member

Thanks @robertpro for the PR! Buen trabajo! 🎉

@pascalin
Copy link

Congratulations @robertpro!

@robertpro robertpro deleted the bpo-24053 branch March 12, 2020 14:41
@robertpro
Copy link
Contributor Author

@pablogsal @pascalin Gracias amigos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants