Skip to content

[3.8] closes bpo-37803: pdb: fix handling of options (--help / --version) (GH-15193) #16066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2019
Merged

[3.8] closes bpo-37803: pdb: fix handling of options (--help / --version) (GH-15193) #16066

merged 1 commit into from
Sep 12, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 12, 2019 •
edited by bedevere-bot
Loading

The "--" should not be included with long options passed to
getopt.getopt.

Fixes https://bugs.python.org/issue37803
(cherry picked from commit 855df7f)

Co-authored-by: Daniel Hahler [email protected]

https://bugs.python.org/issue37803

@blueyed @miss-islington
closes bpo-37803: pdb: fix handling of options (--help / --version) (p…
90e3451 
…ythonGH-15193)

The "--" should not be included with long options passed to
getopt.getopt.

Fixes https://bugs.python.org/issue37803
(cherry picked from commit 855df7f)

Co-authored-by: Daniel Hahler <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Sep 12, 2019
Merged
@miss-islington
Copy link
Contributor Author

@blueyed and @benjaminp: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 21bfff9 into python:3.8 Sep 12, 2019
@miss-islington miss-islington deleted the backport-855df7f-3.8 branch September 12, 2019 16:05
@miss-islington
Copy link
Contributor Author

@blueyed and @benjaminp: Status check is done, and it's a success ✅ .

@blueyed
Copy link
Contributor

blueyed commented Sep 12, 2019 •
edited
Loading

@miss-islington
Might be a good idea to only mention on failures? (for automatic backports)
(I got like 4+ notifications due to this being backported to 3.7 and 3.8)
=> python/miss-islington#272

@miss-islington
Copy link
Contributor Author

@blueyed and @benjaminp: Status check is done, and it's a success ✅ .

@blueyed blueyed mentioned this pull request Sep 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminp benjaminp benjaminp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @blueyed @benjaminp @the-knights-who-say-ni @bedevere-bot