bpo-36946:Fix possible signed integer overflow when handling slices #15639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misc/NEWS.d/next/Core and Builtins/2019-09-02-16-17-42.bpo-36946._lAuSR.rst
Outdated
Show resolved
Hide resolved
hongweipeng
changed the title
|
I have checked all of |
serhiy-storchaka
approved these changes
Sep 8, 2019
| def test_step_overflow(self): | ||
| a = [0, 1, 2, 3, 4] | ||
| a[1::sys.maxsize] = [0] | ||
| self.assertEqual(a[3::sys.maxsize], [3]) |
There was a problem hiding this comment.
Maybe add also the assertion for the whole list after modification?
self.assertEqual(a, [...])
|
Thanks @hongweipeng for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-15729 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 8, 2019
…ythonGH-15639) This is a complement to PR 13375. (cherry picked from commit 3c87a66) Co-authored-by: HongWeipeng <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 8, 2019
…H-15639) This is a complement to PR 13375. (cherry picked from commit 3c87a66) Co-authored-by: HongWeipeng <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…ythonGH-15639) This is a complement to PR 13375.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…ythonGH-15639) This is a complement to PR 13375.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…ythonGH-15639) This is a complement to PR 13375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complement to that PR #13375 .
https://bugs.python.org/issue36946