bpo-37763: Teach setup.py to pick up "-isystem <dir>" from $CPPFLAGS #15136
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When (cross-)compiling, setup.py will pick up header search dirs from $CPPFLAGS and lib search dirs from $LDFLAGS. However, the code only looks at the -I options in $CPPFLAGS to find header search dirs. Using the -isystem option (instead of -I) to pass header search dirs is also a valid option, but this is currently unsupported by setup.py. This patch adds handling of -isystem options, so that these are picked up the same way that -I options currently are.
|
Thanks for you PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When (cross-)compiling, setup.py will pick up header search dirs from
$CPPFLAGS and lib search dirs from $LDFLAGS. However, the code only
looks at the -I options in $CPPFLAGS to find header search dirs.
Using the -isystem option (instead of -I) to pass header search dirs is
also a valid option, but this is currently unsupported by setup.py.
This patch adds handling of -isystem options, so that these are picked
up the same way that -I options currently are.
https://bugs.python.org/issue37763