Skip to content

GH-142513: fix missing return in executor_clear #143073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fidget-Spinner merged 1 commit into from
Dec 22, 2025
Merged

GH-142513: fix missing return in executor_clear #143073

Fidget-Spinner merged 1 commit into from
Dec 22, 2025

Conversation

@chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Dec 22, 2025 •
edited by bedevere-app bot
Loading

Fixes also the warnings like

C:\a\cpython\cpython\Python\optimizer.c(1776): warning C4716: 'executor_clear': must return a value

seen in CI, e.g. https://github.com/python/cpython/actions/runs/20434930925/job/58714738349?pr=143068.

@bedevere-app bedevere-app bot mentioned this pull request Dec 22, 2025
Open
@chris-eibl chris-eibl mentioned this pull request Dec 22, 2025
Merged
@chris-eibl chris-eibl mentioned this pull request Dec 22, 2025
Merged
@chris-eibl
Copy link
Member Author

chris-eibl commented Dec 22, 2025

Ups, jit CI still flaky :(

@Fidget-Spinner Fidget-Spinner merged commit 700e9fa into python:main Dec 22, 2025
64 of 66 checks passed
@chris-eibl chris-eibl deleted the fix-executor_clear-ret-val branch December 22, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chris-eibl @Fidget-Spinner