gh-138122: Tachyon Flamegraph: Make toggle keyboard accesible and adjust sidebar collapse CSS #142638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op the toggle moving when swicted
…cards and transition is smoother. Remove inconsistent margin between legend and rest.
savannahostrowski
approved these changes
Dec 12, 2025
Member
savannahostrowski
left a comment
savannahostrowski
left a comment
There was a problem hiding this comment.
Tested it out! It looks great, thanks!
pablogsal
approved these changes
Dec 12, 2025
ivonastojanovic
approved these changes
Dec 12, 2025
Contributor
ivonastojanovic
left a comment
ivonastojanovic
left a comment
There was a problem hiding this comment.
@StanFromIreland Thanks! This looks great!
Member
Author
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Flamegraph invert toggle keyboard accessible, add title and stop the toggle moving when switched.
Convert "View Mode" to section, adjust CSS so collapse works for all cards and transition is smoother. Remove inconsistent margin between legend and rest.
Screencast.From.2025-12-12.16-51-39.mp4