Skip to content

gh-142624: Make test_inspect's _pickle requirement optional #142625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youknowone wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

gh-142624: Make test_inspect's _pickle requirement optional #142625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bc265a
Make test_inspect _pickle requirements optional
youknowone Dec 12, 2025
9c4147d
apply review
youknowone Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Lib/test/test_inspect/test_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import os
import dis
from os.path import normcase
import _pickle
import pickle
import shutil
import stat
Expand All @@ -29,6 +28,11 @@
import warnings
import weakref

try:
import _pickle
except ImportError:
_pickle = None


try:
from concurrent.futures import ThreadPoolExecutor
Expand Down Expand Up @@ -1410,6 +1414,7 @@ def test(): pass

@unittest.skipIf(MISSING_C_DOCSTRINGS,
"Signature information for builtins requires docstrings")
@unittest.skipUnless(_pickle, "requires _pickle module")
def test_getfullargspec_builtin_methods(self):
self.assertFullArgSpecEquals(_pickle.Pickler.dump, ['self', 'obj'])

Expand Down Expand Up @@ -4635,6 +4640,7 @@ class D(C): pass

@unittest.skipIf(MISSING_C_DOCSTRINGS,
"Signature information for builtins requires docstrings")
@unittest.skipUnless(_pickle, "requires _pickle module")
def test_signature_on_builtin_class(self):
expected = ('(file, protocol=None, fix_imports=True, '
'buffer_callback=None)')
Expand Down Expand Up @@ -5176,6 +5182,7 @@ class foo: pass

@unittest.skipIf(MISSING_C_DOCSTRINGS,
"Signature information for builtins requires docstrings")
@unittest.skipUnless(_pickle, "requires _pickle module")
def test_signature_from_callable_builtin_obj(self):
class MySignature(inspect.Signature): pass
sig = MySignature.from_callable(_pickle.Pickler)
Expand Down
Loading