-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-138122: Add exception profiling mode to the sampling profiler #142561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2746f4a to
d756ae5
Compare
When profiling code it's often valuable to understand what code paths are executing while exceptions are being handled. The new --mode=exception option filters samples to only include threads that have an active exception, making it easy to identify hot spots in error handling code without noise from normal execution paths. This works by checking both the thread's current_exception (for exceptions being raised/propagated) and exc_info (for exceptions being handled in except blocks). The feature integrates with the existing profiler infrastructure including the live TUI, flamegraph output, and gecko format for Firefox Profiler visualization.
d756ae5 to
c316046
Compare
savannahostrowski
requested changes
Dec 11, 2025
|
When you're done making the requested changes, leave the comment: |
savannahostrowski
approved these changes
Dec 11, 2025
StanFromIreland
approved these changes
Dec 11, 2025
Member
StanFromIreland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
Author
|
Thanks for the reviews @StanFromIreland and @savannahostrowski ! |
fatelei
pushed a commit
to fatelei/cpython
that referenced
this pull request
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling code it's often valuable to understand what
code paths are executing while exceptions are being handled. The new
--mode=exception option filters samples to only include threads that
have an active exception, making it easy to identify hot spots in error
handling code without noise from normal execution paths.
This works by checking both the thread's current_exception (for
exceptions being raised/propagated) and exc_info (for exceptions being
handled in except blocks). The feature integrates with the existing
profiler infrastructure including the live TUI, flamegraph output, and
gecko format for Firefox Profiler visualization.
📚 Documentation preview 📚: https://cpython-previews--142561.org.readthedocs.build/