gh-138122: Integrate live profiler TUI with _colorize theming system #142360
+198
−77
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -639,8 +639,6 @@ def render(self, line, width, **kwargs): | |
|
|
||
| def draw_column_headers(self, line, width): | ||
| """Draw column headers with sort indicators.""" | ||
| # Determine which columns to show based on width | ||
| show_sample_pct = width >= WIDTH_THRESHOLD_SAMPLE_PCT | ||
| show_tottime = width >= WIDTH_THRESHOLD_TOTTIME | ||
|
|
@@ -659,38 +657,38 @@ def draw_column_headers(self, line, width): | |
| "cumtime": 4, | ||
| }.get(self.collector.sort_by, -1) | ||
|
|
||
| # Build the full header line first, then draw it | ||
| # This avoids gaps between columns when using reverse video | ||
| header_parts = [] | ||
| col = 0 | ||
|
|
||
| # Column 0: nsamples | ||
| text = f"{'▼nsamples' if sort_col == 0 else 'nsamples':>13} " | ||
| header_parts.append((col, text, sorted_header if sort_col == 0 else normal_header)) | ||
| col += 15 | ||
|
|
||
| # Column 1: sample % | ||
| if show_sample_pct: | ||
| text = f"{'▼%' if sort_col == 1 else '%':>5} " | ||
| header_parts.append((col, text, sorted_header if sort_col == 1 else normal_header)) | ||
| col += 7 | ||
|
|
||
| # Column 2: tottime | ||
| if show_tottime: | ||
| text = f"{'▼tottime' if sort_col == 2 else 'tottime':>10} " | ||
| header_parts.append((col, text, sorted_header if sort_col == 2 else normal_header)) | ||
| col += 12 | ||
|
|
||
| # Column 3: cumul % | ||
| if show_cumul_pct: | ||
| text = f"{'▼%' if sort_col == 3 else '%':>5} " | ||
| header_parts.append((col, text, sorted_header if sort_col == 3 else normal_header)) | ||
| col += 7 | ||
|
|
||
| # Column 4: cumtime | ||
| if show_cumtime: | ||
| text = f"{'▼cumtime' if sort_col == 4 else 'cumtime':>10} " | ||
| header_parts.append((col, text, sorted_header if sort_col == 4 else normal_header)) | ||
| col += 12 | ||
|
|
||
| # Remaining headers | ||
|
|
@@ -700,13 +698,22 @@ def draw_column_headers(self, line, width): | |
| MAX_FUNC_NAME_WIDTH, | ||
| max(MIN_FUNC_NAME_WIDTH, remaining_space // 2), | ||
| ) | ||
| text = f"{'function':<{func_width}} " | ||
| header_parts.append((col, text, normal_header)) | ||
| col += func_width + 2 | ||
|
|
||
| if col < width - 10: | ||
| file_text = "file:line" | ||
| padding = width - col - len(file_text) | ||
| text = file_text + " " * max(0, padding) | ||
| header_parts.append((col, text, normal_header)) | ||
|
|
||
| # Draw full-width background first | ||
| self.add_str(line, 0, " " * (width - 1), normal_header) | ||
|
|
||
| # Draw each header part on top | ||
| for col_pos, text, attr in header_parts: | ||
| self.add_str(line, col_pos, text.rstrip(), attr) | ||
|
|
||
| return ( | ||
| line + 1, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| The Tachyon profiler's live TUI now integrates with the experimental | ||
| :mod:`!_colorize` theming system, allowing users to customize colors via | ||
| :func:`!_colorize.set_theme`. A :class:`!LiveProfilerLight` theme is provided | ||
| for light terminal backgrounds. Patch by Pablo Galindo. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather have this one after the for-loop as it's not tied to ANSI colors.