gh-141794: Reduce size of compiler stress tests to fix Android warnings #142263
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsmith
added
needs backport to 3.13
Member
Author
|
I've updated this to change the sizes only on Android, and the tests are now passing on all platforms, so this PR is ready to review. Due to #142289, the tests are now running on API level 35, so the low memory warnings are much less detailed. Search for the |
Eclips4
approved these changes
Dec 7, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 7, 2025
…warnings (pythonGH-142263) (cherry picked from commit f193c8f) Co-authored-by: Malcolm Smith <[email protected]>
|
Sorry, @mhsmith and @Eclips4, I could not cleanly backport this to |
|
GH-142386 is a backport of this pull request to the 3.14 branch. |
mhsmith
added a commit
to mhsmith/cpython
that referenced
this pull request
Dec 8, 2025
…ndroid warnings (pythonGH-142263) (cherry picked from commit f193c8f) Co-authored-by: Malcolm Smith <[email protected]>
|
GH-142409 is a backport of this pull request to the 3.13 branch. |
Eclips4
pushed a commit
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Android low memory warnings in
test_astandtest_compile, previously discussed in #137186 (comment).These warnings haven't led to a crash so far. However, the warning will only appear during the first test that brings the memory below a threshold. If a later test exhausts the memory completely, then the warning won't appear again, and the process will simply crash. This separation between the warning and the crash makes the crash much more difficult to understand.
I think this may have been what happened in #142228 (comment), which introduced some leaks. Notice in this run, the warning appeared during
test_ast, and the crash happened intest_random.