Skip to content

GH-142050: Jit stencils on Windows contain debug data #142052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savannahostrowski merged 5 commits into from
Dec 3, 2025
Merged

GH-142050: Jit stencils on Windows contain debug data #142052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c4fab1
skip debug COFF sections on Windows
chris-eibl Nov 28, 2025
6e5fd82
blurb it
chris-eibl Nov 28, 2025
102fb68
make mypy happy
chris-eibl Nov 28, 2025
1914f2e
Update Misc/NEWS.d/next/Build/2025-11-28-21-43-07.gh-issue-142050.PFi…
chris-eibl Dec 2, 2025
1dd060c
Merge branch 'main' into shrink-stencils
savannahostrowski Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2025-11-28-21-43-07.gh-issue-142050.PFi4tv.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a bug where JIT stencils produced on Windows contained debug data. Patch by Chris Eibl.
1 change: 1 addition & 0 deletions Tools/jit/_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ class COFFSection(typing.TypedDict):
Characteristics: dict[
typing.Literal["Flags"], list[dict[typing.Literal["Name"], str]]
]
Name: dict[typing.Literal["Value"], str]
Number: int
RawDataSize: int
Relocations: list[dict[typing.Literal["Relocation"], COFFRelocation]]
Expand Down
4 changes: 4 additions & 0 deletions Tools/jit/_targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,10 @@ class _COFF(
def _handle_section(
self, section: _schema.COFFSection, group: _stencils.StencilGroup
) -> None:
name = section["Name"]["Value"]
if name == ".debug$S":
# skip debug sections
return
flags = {flag["Name"] for flag in section["Characteristics"]["Flags"]}
if "SectionData" in section:
section_data_bytes = section["SectionData"]["Bytes"]
Expand Down
Loading