Skip to content

[3.5] bpo-30107: don't dump core on expected test_io crash (#1235) #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2017
Merged

[3.5] bpo-30107: don't dump core on expected test_io crash (#1235) #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2bddd4
bpo-30107: Make SuppressCrashReport quiet on macOS (#1279) (#1335)
vstinner Apr 28, 2017
a86692d
bpo-30107: don't dump core on expected test_io crash (#1235)
vstinner Apr 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Lib/test/support/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2337,17 +2337,22 @@ def __enter__(self):
(0, self.old_value[1]))
except (ValueError, OSError):
pass

if sys.platform == 'darwin':
# Check if the 'Crash Reporter' on OSX was configured
# in 'Developer' mode and warn that it will get triggered
# when it is.
#
# This assumes that this context manager is used in tests
# that might trigger the next manager.
value = subprocess.Popen(['/usr/bin/defaults', 'read',
'com.apple.CrashReporter', 'DialogType'],
stdout=subprocess.PIPE).communicate()[0]
if value.strip() == b'developer':
cmd = ['/usr/bin/defaults', 'read',
'com.apple.CrashReporter', 'DialogType']
proc = subprocess.Popen(cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE)
with proc:
stdout = proc.communicate()[0]
if stdout.strip() == b'developer':
print("this test triggers the Crash Reporter, "
"that is intentional", end='', flush=True)

Expand Down
5 changes: 5 additions & 0 deletions Lib/test/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3688,6 +3688,7 @@ def check_daemon_threads_shutdown_deadlock(self, stream_name):
import sys
import time
import threading
from test.support import SuppressCrashReport

file = sys.{stream_name}

Expand All @@ -3696,6 +3697,10 @@ def run():
file.write('.')
file.flush()

crash = SuppressCrashReport()
crash.__enter__()
# don't call __exit__(): the crash occurs at Python shutdown

thread = threading.Thread(target=run)
thread.daemon = True
thread.start()
Expand Down