gh-114713: Revert gh-114731 #133330
Merged
gh-114713: Revert gh-114731 #133330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neinfo.ZoneInfo` (python#114731)" This reverts commit 884df11.
|
Thanks @Eclips4 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 3, 2025
Revert "pythongh-114713: Handle case of an empty string passed to `zoneinfo.ZoneInfo` (pythonGH-114731)" This reverts commit 884df11. (cherry picked from commit fe44fc4) Co-authored-by: Kirill Podoprigora <[email protected]>
|
GH-133331 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, #114731 introduced a regression and
zoneinfo.ZoneInfo(None)now raises aValueErrorinstead ofTypeError, which may break some tests in 3rd party libraries (such as https://github.com/reagento/adaptix/).Therefore, I'm reverting it before 3.14b1. The original issue isn't critical, and we can address it later.
''#114713