Skip to content

gh-132781: Cleanup Code Related to NotShareableError #132782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 25, 2025
Merged

gh-132781: Cleanup Code Related to NotShareableError #132782

merged 9 commits into from
Apr 25, 2025

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Apr 21, 2025 •
edited by bedevere-app bot
Loading

Key changes:

  • add to internal C-API:
    • _PyErr_FormatV()
    • _PyErr_SetModuleNotFoundError()
    • _PyXIData_GetNotShareableErrorType()
    • _PyXIData_FormatNotShareableError()
  • drop _PyXIData_lookup_context_t and _PyXIData_GetLookupContext()

@bedevere-app bedevere-app bot mentioned this pull request Apr 21, 2025
Closed
@ericsnowcurrently ericsnowcurrently merged commit cd9536a into python:main Apr 25, 2025
41 checks passed
@ericsnowcurrently ericsnowcurrently deleted the not-shareable-error-cleanup branch April 25, 2025 20:43
@picnixz
Copy link
Member

picnixz commented Apr 26, 2025

This introduced refleaks which I fixed in #132989.

picnixz added a commit that referenced this pull request Apr 26, 2025
@picnixz
gh-132781: fix refleaks in crossinterp_exceptions.h post gh-132782 (#…
ca12a74 
…132989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsnowcurrently @picnixz