Skip to content

[3.13] gh-118201: Simplify conv_confname (#126089) #131375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Mar 17, 2025

(cherry picked from commit c5c9286)

This wasn't originally backported because the failure wasn't happening on the 3.13 branch, but now it's happened twice in the last week:

The fix has been on the main branch for several months now, and the failure hasn't happened there again on either Android or iOS.

@mhsmith
Copy link
Member Author

mhsmith commented Mar 17, 2025

!buildbot android|ios

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 9466eb8 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131375%2Fmerge

The command will test the builders whose names match following regular expression: android|ios

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR
  • iOS ARM64 Simulator PR

@mhsmith mhsmith requested a review from freakboy3742 March 17, 2025 19:56
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks like a fairly vanilla back port (that is only complicated by the generated portions); and the stability of the change on the main branch (plus the ABI stability check on CI for this PR) suggests it's having the desired effect.

@freakboy3742 freakboy3742 merged commit e8e6e30 into python:3.13 Mar 18, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants