gh-128540: lookup default webbrowser on Windows #130538
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lookup default browsers via
UrlAssociations\https\UserChoice
if protocol is not http/https. ensureswebbrowser.open
launches a web browser on Windows, even for URLs that are not http[s]. Only does the lookup for non-http URLs, limiting the impact of the change.ensures browser is opened for e.g.
file://
URLs, wherestartfile
opens file by association. Launching custom protocols explicitly goes through the browser instead of throughstartfile
. The end result is usually the same, after a prompt, unless the browser has explicit support/configuration for the protocol. Alternative: only lookup forfile://
instead of nothttp[s]://
.Added extremely basic test exercise, the registry lookups are not actually covered, but I have tested them by hand. I'm not sure how to write good tests for the registry stuff.
Addresses gh-128540 on Windows only.
Open questions:
os.startfile("ssh://some-host")
might start putty or something, whereas this explicitly launches the browser (which would in turn typically prompt "launch external application PuTTy..?"). Behavior for custom URLs is previously undefined and inconsistent, but after this PR, it consistently launches a webbrowser if it can, but remains undefined.open
command-line lack%1
and still be valid (e.g. withappend
)? I can't find a spec for this, so it would be good to know. I've gone with the most conservative, which is to assume it doesn't work if%1
is not present, falling back on previousos.startfile
in that case.Links: