Docs: Test presence of optional extensions with importlib #130445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
added
docs
hugovk
approved these changes
Feb 22, 2025
| extensions.append(optional_ext) | ||
| except (ImportError, ValueError): | ||
| pass | ||
| del _OPTIONAL_EXTENSIONS |
There was a problem hiding this comment.
Does this make much difference?
Suggested change
| del _OPTIONAL_EXTENSIONS |
There was a problem hiding this comment.
We should avoid polluting the conf.py namespace, as it is read for Sphinx configuration. The underscore and del may be overkill, but just being explicit.
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 22, 2025
…30445) (cherry picked from commit 3cc9e86) Co-authored-by: Adam Turner <[email protected]>
|
GH-130464 is a backport of this pull request to the 3.13 branch. |
|
Sorry, @AA-Turner, I could not cleanly backport this to |
AA-Turner
added a commit
to AA-Turner/cpython
that referenced
this pull request
Feb 22, 2025
…honGH-130445) (cherry picked from commit 3cc9e86) Co-authored-by: Adam Turner <[email protected]>
|
GH-130466 is a backport of this pull request to the 3.12 branch. |
AA-Turner
added a commit
that referenced
this pull request
Feb 22, 2025
…130445) (#130464) (cherry picked from commit 3cc9e86) Co-authored-by: Adam Turner <[email protected]>
AA-Turner
added a commit
that referenced
this pull request
Feb 22, 2025
…130445) (#130466) * [3.12] Docs: Test presence of optional extensions with importlib (GH-130445) (cherry picked from commit 3cc9e86) Co-authored-by: Adam Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to import the extensions, and this is more compact if we add more optional extensions.
A
📚 Documentation preview 📚: https://cpython-previews--130445.org.readthedocs.build/