Skip to content

Conversation

Sabfo
Copy link
Contributor

@Sabfo Sabfo commented Feb 19, 2025

Clarify the meaning dataclasses.field(..., hash=False)


📚 Documentation preview 📚: https://cpython-previews--130324.org.readthedocs.build/

@Sabfo Sabfo requested a review from ericvsmith as a code owner February 19, 2025 21:15
@ghost
Copy link

ghost commented Feb 19, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Feb 19, 2025
@sobolevn sobolevn changed the title Fix issue 130130 gh-130130: Clarify hash=False docs in dataclasses.field Feb 19, 2025
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for @ericvsmith's review :)

Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericvsmith ericvsmith merged commit 47ace53 into python:main Feb 20, 2025
35 checks passed
@sobolevn
Copy link
Member

@Sabfo congrats on your first PR! 🎉
Please, continue your work :)

@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 20, 2025
@miss-islington-app
Copy link

Thanks @Sabfo for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @Sabfo for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented Feb 20, 2025

GH-130336 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented Feb 20, 2025

GH-130337 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 20, 2025
@sobolevn
Copy link
Member

We usually backport doc changes, unless this behavior is new.

sobolevn pushed a commit that referenced this pull request Feb 20, 2025
…H-130324) (#130337)

gh-130130: Clarify `hash=False` docs in `dataclasses.field` (GH-130324)
(cherry picked from commit 47ace53)

Co-authored-by: Sabfo <[email protected]>
@Sabfo Sabfo deleted the fix-issue-130130 branch February 20, 2025 07:51
sobolevn pushed a commit that referenced this pull request Feb 20, 2025
…H-130324) (#130336)

gh-130130: Clarify `hash=False` docs in `dataclasses.field` (GH-130324)
(cherry picked from commit 47ace53)

Co-authored-by: Sabfo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants