gh-130177: Fix skipped tests in test_gettext
#130178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
added
skip news
needs backport to 3.12
|
@serhiy-storchaka You were last to modify them a few years ago, just checking this wasn't intentional for some reason? |
|
Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 16, 2025
…ythonGH-130178) (cherry picked from commit 2e8044a) Co-authored-by: Tomas R. <[email protected]>
|
GH-130183 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 16, 2025
…ythonGH-130178) (cherry picked from commit 2e8044a) Co-authored-by: Tomas R. <[email protected]>
|
GH-130184 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 16, 2025
…H-130178) (GH-130184) (cherry picked from commit 2e8044a) Co-authored-by: Tomas R <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 16, 2025
…H-130178) (GH-130183) (cherry picked from commit 2e8044a) Co-authored-by: Tomas R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
test_gettextbefore:and after:
test_gettext#130177