Skip to content

Some tests are skipped in test_gettext #130177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomasr8 opened this issue Feb 16, 2025 · 1 comment
Closed

Some tests are skipped in test_gettext #130177

tomasr8 opened this issue Feb 16, 2025 · 1 comment
Assignees
@tomasr8
Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@tomasr8
Copy link
Member

tomasr8 commented Feb 16, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

PluralFormsInternalTestCase does not inherit from unittest.TestCase so the test is not picked up:

cpython/Lib/test/test_gettext.py

Lines 405 to 407 in 9837c2a

class PluralFormsInternalTestCase:
# Examples from http://www.gnu.org/software/gettext/manual/gettext.html

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@tomasr8 tomasr8 added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Feb 16, 2025
@tomasr8 tomasr8 self-assigned this Feb 16, 2025
@bedevere-app bedevere-app bot mentioned this issue Feb 16, 2025
Merged
serhiy-storchaka pushed a commit that referenced this issue Feb 16, 2025
@tomasr8
gh-130177: Fix unintentionally skipped tests in test_gettext (GH-130178)
2e8044a
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 16, 2025
@tomasr8 @miss-islington
pythongh-130177: Fix unintentionally skipped tests in test_gettext (p…
bcbc5a5 
…ythonGH-130178)

(cherry picked from commit 2e8044a)

Co-authored-by: Tomas R. <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 16, 2025
@tomasr8 @miss-islington
pythongh-130177: Fix unintentionally skipped tests in test_gettext (p…
d2898c9 
…ythonGH-130178)

(cherry picked from commit 2e8044a)

Co-authored-by: Tomas R. <[email protected]>
This was referenced Feb 16, 2025
Merged
Merged
@serhiy-storchaka
Copy link
Member

Thanks @tomasr8 for noticing and fixing this.

@serhiy-storchaka serhiy-storchaka added 3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes labels Feb 16, 2025
serhiy-storchaka pushed a commit that referenced this issue Feb 16, 2025
@miss-islington @tomasr8
[3.12] gh-130177: Fix unintentionally skipped tests in test_gettext (G…
b85f061 
…H-130178) (GH-130184)

(cherry picked from commit 2e8044a)

Co-authored-by: Tomas R <[email protected]>
serhiy-storchaka pushed a commit that referenced this issue Feb 16, 2025
@miss-islington @tomasr8
[3.13] gh-130177: Fix unintentionally skipped tests in test_gettext (G…
5d240c7 
…H-130178) (GH-130183)

(cherry picked from commit 2e8044a)

Co-authored-by: Tomas R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasr8 tomasr8

Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
Gettext issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@serhiy-storchaka @tomasr8