Skip to content

gh-127146: skip Emscripten tests with pending fixes #128549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 6, 2025
Merged

gh-127146: skip Emscripten tests with pending fixes #128549

merged 5 commits into from
Jan 6, 2025

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jan 6, 2025 •
edited
Loading

Skip some tests failures that are either fixed on the main branch of Emscripten or by an open PR.

@hoodmane hoodmane requested a review from freakboy3742 January 6, 2025 14:15
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jan 6, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 6, 2025
Open
@hoodmane hoodmane changed the title gh-127146: skip tests that are fixed on the main branch of Emscripten gh-127146: skip Emscripten tests with pending fixes Jan 6, 2025
@brettcannon brettcannon removed their request for review January 6, 2025 17:26
freakboy3742
freakboy3742 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@freakboy3742 freakboy3742 merged commit 616692d into python:main Jan 6, 2025
40 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Skip Emscripten tests with pending fixes (python#128549
9c5b386 
)

Marks some additional tests as skipped on Emscripten. Many of these skips can be
reverted when the next Emscripten release is available.
@hoodmane hoodmane deleted the emscripten-main-branch-fixed branch January 8, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @freakboy3742