gh-128049: Fix type confusion bug with the return value of a custom ExceptionGroup split function #128079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nico-Posada
requested review from
iritkatriel and
markshannon
as code owners
|
Labelling as do not merge until discussion on the issue is resolved. |
iritkatriel
reviewed
Dec 18, 2024
Misc/NEWS.d/next/Core_and_Builtins/2024-12-18-14-22-48.gh-issue-128079.SUD5le.rst
Outdated
Show resolved
Hide resolved
iritkatriel
reviewed
Dec 18, 2024
iritkatriel
reviewed
Dec 18, 2024
iritkatriel
reviewed
Dec 20, 2024
iritkatriel
added
needs backport to 3.12
iritkatriel
approved these changes
Dec 20, 2024
|
Thank you @Nico-Posada ! |
|
Thanks @Nico-Posada for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 20, 2024
…stom ExceptionGroup split function (pythonGH-128079) (cherry picked from commit 3879ca0) Co-authored-by: Nico-Posada <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 20, 2024
…stom ExceptionGroup split function (pythonGH-128079) (cherry picked from commit 3879ca0) Co-authored-by: Nico-Posada <[email protected]>
|
GH-128139 is a backport of this pull request to the 3.13 branch. |
|
GH-128140 is a backport of this pull request to the 3.12 branch. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Dec 23, 2024
…stom ExceptionGroup split function (python#128079)
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…stom ExceptionGroup split function (python#128079)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128049
Still new to this whole process so feedback is appreciated :)