Skip to content

gh-127146: Some expected failures in Emscripten time tests #127843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

gh-127146: Some expected failures in Emscripten time tests #127843

merged 1 commit into from
Dec 12, 2024

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Dec 11, 2024 •
edited by bedevere-app bot
Loading

This xfails two tests in the test_time suite. It also adjusts test_os to reflect the fact that in Emscripten file modification times in nanoseconds since the linux epoch get round tripped through a 53 bit integer so we only get 5 subsecond digits of precision.

@hoodmane
pythongh-127146: Emscripten some expected failures in time tests
262634c 
This xfails two tests in the test_time suite. It also adjusts test_os
to reflect the fact that in Emscripten file modification times in
nanoseconds since the linux epoch get round tripped through a 53 bit
integer so we only get 5 subsecond digits of precision.
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Dec 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 11, 2024
Open
@hoodmane hoodmane changed the title gh-127146: Emscripten some expected failures in time tests gh-127146: Some expected failures in Emscripten time tests Dec 11, 2024
freakboy3742
freakboy3742 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 An annoying discrepancy on subsection accuracy, but this is a pragmatic workaround until such time as this can be fixed upstream.

@freakboy3742 freakboy3742 merged commit 41f29e5 into python:main Dec 12, 2024
46 checks passed
@hoodmane hoodmane deleted the emscripten-time-tests branch December 12, 2024 09:23
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Some expected failures in Emscripten time tests (pyt…
c9158b1 
…hon#127843)

Disables two tests in the test_time suite, and adjusts test_os to reflect 
precision limits in Emscripten.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @freakboy3742